Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --re-ignore #44

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Fix --re-ignore #44

merged 2 commits into from
Aug 12, 2023

Conversation

drammock
Copy link
Contributor

This PR does 2 things:

  1. correct the help text for the --re-ignore arg to stb serve (introduced in expose re-ignore in stb serve #41)
  2. removes the re.escape around the user-passed regex, so that users can do things like session.run("stb", "serve", "docs", "--re-ignore=locale|api") (noxfile) or stb serve docs --re-ignore=locale\|api (command line) and not have the | in locale|api get escaped

crossref: pydata/pydata-sphinx-theme#1359

@drammock drammock changed the title Fix re ignore Fix --re-ignore Jun 26, 2023
@pradyunsg pradyunsg merged commit 87214d0 into pradyunsg:main Aug 12, 2023
@drammock drammock deleted the fix-re-ignore branch October 25, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants